Update compaction techniques #60
Conversation
DomGarguilo
changed the title
|
I don't know enough about the new compaction configuration to review this. I requested a review from @keith-turner or @dlmarion , who I think could assess it better. |
| org.apache.accumulo.core.client.admin.PluginConfig cpc = new org.apache.accumulo.core.client.admin.PluginConfig( | ||
| configurerConfig.getClassName(), options); | ||
|
|
||
| compactionConfig.setConfigurer(cpc); |
There was a problem hiding this comment.
This new logic looks correct, appears to match the code in CompactCommand.setupConfigurableCompaction.
# Conflicts: # src/test/java/org/apache/accumulo/proxy/its/SimpleProxyBase.java
|
Everything looks good here to me and the tests pass when run with my IDE but when running in the terminal, there is an error |
…elector.java to src/test/java/org/apache/accumulo/proxy/its/SelectHalfSelector.java Fix jar sealing error
Fix jar sealing import
Resolve merge conflicts for PR apache#60
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
I fixed the merge conflicts and the jar sealing issue. The changes look okay to me, and it was previously approved, so I'll merge it. The ITs are still failing, but that's for another issue.
3 participants
This PR aims to replace the deprecated compaction methods with the new ones.
Fixes #47
CompactionSelectorI'm not sure that this is the best place to have the
CompactionSelectoras it is only used for testing so I will probably move it but just wanted to get something working together first.I also plan on looking into adding a test for custom
CompactionConfigurertoo.