Update dependency and plugin versions #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warnings due to updated dependencies * Use new vfs2 method instead of deprecated one * Use assertThrows instead of ExpectedException * Remove hamcrest dependency, because it's not needed any more
Enforce dependency convergence to versions specified in the dependencyManagement section when transitive dependencies from different direct dependencies conflict. Fix broken tests due to bad runtime class path for hadoop client jars by excluding hadoop-hdfs-client from transitive dependencies via commons-vfs2. The dependency is already included in the shaded hadoop-client-runtime and we should not have the non-shaded version on the class path.
Contributor
milleruntime
left a comment
milleruntime
left a comment
There was a problem hiding this comment.
I think these are generally all needed updates but I worry about updating so many different dependencies in a single commit. While they are mostly minor updates, so many different updates in one commit will make debugging more difficult if this breaks something.
Member
Author
There's only one breakage in the full build with tests: I'm currently working through what's going on with that one. |
asfgit
pushed a commit
that referenced
this pull request
Dec 15, 2020
Update JUnit dependency, and use assertThrows instead of ExpectedException Rule and hamcrest library, to avoid deprecation warnings and an unnecessary test dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings due to updated dependencies