Skip to content

Moved the ZooKeeper 3.5.x compatibility check to targets other than main #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dlmarion wants to merge 1 commit into from
Closed

Moved the ZooKeeper 3.5.x compatibility check to targets other than main #3203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/maven.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ jobs:
profile:
- {name: 'unit-tests', javaver: 11, args: 'verify -PskipQA -DskipTests=false'}
- {name: 'qa-checks', javaver: 11, args: 'verify javadoc:jar -Psec-bugs -DskipTests -Dspotbugs.timeout=3600000'}
- {name: 'compat', javaver: 11, args: 'package -DskipTests -Dhadoop.version=3.0.3 -Dzookeeper.version=3.5.10'}
- {name: 'errorprone', javaver: 11, args: 'verify -Perrorprone,skipQA'}
- {name: 'jdk17', javaver: 17, args: 'verify -DskipITs'}
fail-fast: false
Expand Down Expand Up @@ -110,6 +109,12 @@ jobs:
run: mvn -B -V -e -ntp "-Dstyle.color=always" -DskipFormat ${{ matrix.profile.args }}
env:
MAVEN_OPTS: -Djansi.force=true
- name: Build with Maven (ZooKeeper compatibility build)
if: ${{ github.base_ref != 'main' }}
Copy link
Member

@ctubbsii ctubbsii Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exclude main?

Copy link
Contributor Author

@dlmarion dlmarion Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this change is that #3200 uses newer ZooKeeper API objects, so this check fails. #3200 isn't merged, but if it is, then this is an issue.

Copy link
Member

@ctubbsii ctubbsii Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that's a compelling reason to bump the minimum. What's the minimum for it to work? Can we just modify the one existing line, rather than do the changes proposed in this PR that jumps through hoops to check for main?

Copy link
Contributor Author

@dlmarion dlmarion Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look.

Copy link
Contributor Author

@dlmarion dlmarion Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this, it looks like 3.6.0 might be the minimum.

Copy link
Contributor Author

@dlmarion dlmarion Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will modify the GitHub action file in my branch and see if that resolves it

Copy link
Member

@ctubbsii ctubbsii Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case, then changing it to 3.6.4 (the latest 3.6 bugfix) would probably be appropriate.

Copy link
Contributor Author

@dlmarion dlmarion Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.1 was the minimum. I updated it in my PR, I'm going to close this.

Copy link
Contributor Author

@dlmarion dlmarion Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.1 is the minimum from an API perspective. Do you think the API changed between 3.6.1 and 3.6.4 that would cause an issue, but still works with 3.8.1?

Copy link
Member

@ctubbsii ctubbsii Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope not. That would be uncharacteristically unstable of the ZK team.

timeout-minutes: 60
run: mvn -B -V -e -ntp "-Dstyle.color=always" -DskipFormat package -DskipTests -Dhadoop.version=3.0.3 -Dzookeeper.version=3.5.10
env:
Comment on lines +115 to +116
Copy link
Member

@ctubbsii ctubbsii Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just puts inline what we have previously defined elsewhere. It seems the reason to do this is to exclude the main branch, and not use the normal args, but I'm not sure why we're excluding the main branch.

MAVEN_OPTS: -Djansi.force=true
- name: Upload unit test results
if: ${{ failure() }}
uses: actions/upload-artifact@v3
Expand Down