avoid checking all tablet files in bulk import conditional mutation #5159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the changes in apache#5104 bulk import would read a tablets files, examine the files, and then require the set of files to be the same to update the tablet. The code only cared that the count of files was below a specified limit. Requiring the set of files not to change was causing the conditional mutation to fail on a busy tablet. This change modifies the condition to check the count of file which avoids contention on a busy tablet where the set of files is constantly changing.
keith-turner
changed the title
dlmarion
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes in #5104 bulk import would read a tablets files, examine the files, and then require the set of files to be the same to update the tablet. The code only cared that the count of files was below a specified limit. Requiring the set of files not to change was causing the conditional mutation to fail on a busy tablet. This change modifies the condition to check the count of file which avoids contention on a busy tablet where the set of files is constantly changing.