avoids loop and wrapping iter in PreAllocatedArray #6082
Merged
+28
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Jan 28, 2026
| @Override | ||
| public Iterator<T> iterator() { | ||
| return Iterators.unmodifiableIterator(internal.iterator()); | ||
| return internal.iterator(); |
Contributor
There was a problem hiding this comment.
Is there a reason to no longer wrap?
Contributor
Author
There was a problem hiding this comment.
The list created from an array does not support removal. I added a test to verify this.
dlmarion
approved these changes
Jan 28, 2026
Contributor
Author
|
Seems like PreAllocatedArray could be replaced w/ a single static method like the following. May try this in main. This change is a nice optimization for 2.1. @SuppressWarnings("unchecked")
public static <T> List<T> newPreallocatedList(int size){
return Arrays.asList((T[]) new Object[size]);
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.