Support running MiniAccumuloCluster using Java 11#942
Closed
mikewalch wants to merge 1 commit intoapache:masterfrom
Closed
Support running MiniAccumuloCluster using Java 11#942mikewalch wants to merge 1 commit intoapache:masterfrom
mikewalch wants to merge 1 commit intoapache:masterfrom
Conversation
ctubbsii
approved these changes
Feb 7, 2019
| } else { | ||
| log.debug("Using classpath set by java.class.path system property: {}", javaClassPath); | ||
| } | ||
| classpathBuilder.append(File.pathSeparator).append(javaClassPath); |
Member
There was a problem hiding this comment.
+1; I wonder if we should always do this, even in the case of a URLClassLoader (above). It's so simple, and we don't even need to care at all about what kind of class loader the system class loader is using (although, we are assuming the environment is set... so if a system class loader doesn't use that, the user would have to set it explicitly... but that's fine.)
Member
Author
There was a problem hiding this comment.
I am going to put this change in 1.9 & 2.0 and then I will follow up with a new PR that simplifies it for 2.0
Contributor
|
Would be nice to make this change for 1.9 |
Member
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See apache/accumulo-website#147