AMQ-9743: Fixes Web Console column sorting. #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue registering window.onload JS events, also fixes a call to prettyPrint() with the wrong callback.
jbonofre
approved these changes
Sep 12, 2025
jbonofre
pushed a commit
that referenced
this pull request
Sep 12, 2025
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Oct 17, 2025
mattrpav
pushed a commit
to mattrpav/activemq
that referenced
this pull request
Dec 29, 2025
Fixes an issue registering window.onload JS events, also fixes a call to prettyPrint() with the wrong callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue registering window.onload JS events, also fixes a call to prettyPrint() with the wrong callback.
addEvent()doesn't seem to work well withwindow.onload, resulting in the registered events not being called, including the standardistaTableSortingInit() function which configures the sortable table headers.This PR also fixes an existing error when calling
prettyPrint()as the 'onload' event callback, prettyPrint expects its argument to be a callback but actually received an "event" object.I tested on Chrome browser by navigating the Queues and Topics pages and sorting the table by different columns. Also published, moved, copied and deleted messages.