Fix issue #989: Impossible to create array with > 100 items #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehowef
approved these changes
Jun 20, 2023
Member
dehowef
left a comment
dehowef
left a comment
There was a problem hiding this comment.
Creative solution. Looks good to me
MuhammadTahaNaveed
approved these changes
Jun 21, 2023
Member
MuhammadTahaNaveed
left a comment
MuhammadTahaNaveed
left a comment
There was a problem hiding this comment.
Tested it with SET and nested cases as well. Looks good to me 👍🏻 .
Contributor
Author
|
@MuhammadTahaNaveed Could you provide me (email) with some of those tests? I will add them to the PR. |
Member
Yeah sure. |
jrgemignani
force-pushed
the
big_array_989
branch
from
674ef0e to
4ee7a88
Compare
Fixed issue 989: Impossible to create an object with an array field of more than 100 elements. This issue is due to the function agtype_build_list taking elements as arguments. As the elements can be anything, expressions too, they need to be processed by the transform phase and resolved in the execution phase. As PG has a limitation of 100 function arguments, this restricts the size of arrays built through agtype_build_list. The fix was to break up large lists into segments of 100 items or less and then use the concatenation operator to join them in the execution phase. Added regression tests (thanks Taha!).
Contributor
Author
|
Added Taha's additional regression tests. |
Member
|
Additional tests look good. |
This was
linked to
issues
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 989: Impossible to create an object with an array field of more than 100 elements.
This issue is due to the function agtype_build_list taking elements as arguments. As the elements can be anything, expressions too, they need to be processed by the transform phase and resolved in the execution phase. As PG has a limitation of 100 function arguments, this restricts the size of arrays built through agtype_build_list.
The fix was to break up large lists into segments of 100 items or less and then use the concatenation operator to join them in the execution phase.
Added regression tests.