Skip to content

fix issue 2205: left doesn't catch overflow #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MuhammadTahaNaveed merged 1 commit into from
Aug 18, 2025
Merged

fix issue 2205: left doesn't catch overflow #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions regress/expected/expr.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4556,6 +4556,18 @@ ERROR: function age_left() does not exist
LINE 1: SELECT * FROM age_left();
^
HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('expr', $$
RETURN left('abcdef', -2147483648)
$$) AS (result agtype);
ERROR: left() negative values are not supported for length
SELECT * FROM cypher('expr', $$
RETURN left('abcdef', -2147483649)
$$) AS (result agtype);
ERROR: left() length value is out of INT range
SELECT * FROM cypher('expr', $$
RETURN left('abcdef', 2147483649)
$$) AS (result agtype);
ERROR: left() length value is out of INT range
--right()
SELECT * FROM cypher('expr', $$
RETURN right("123456789", 1)
Expand Down Expand Up @@ -4636,6 +4648,18 @@ ERROR: function age_right() does not exist
LINE 1: SELECT * FROM age_right();
^
HINT: No function matches the given name and argument types. You might need to add explicit type casts.
SELECT * FROM cypher('expr', $$
RETURN right('abcdef', -2147483648)
$$) AS (result agtype);
ERROR: right() negative values are not supported for length
SELECT * FROM cypher('expr', $$
RETURN right('abcdef', -2147483649)
$$) AS (result agtype);
ERROR: right() length value is out of INT range
SELECT * FROM cypher('expr', $$
RETURN right('abcdef', 2147483649)
$$) AS (result agtype);
ERROR: right() length value is out of INT range
-- substring()
SELECT * FROM cypher('expr', $$
RETURN substring("0123456789", 0, 1)
Expand Down Expand Up @@ -4731,6 +4755,30 @@ SELECT * FROM age_substring(null, 1);

(1 row)

SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', -2147483648, 0)
$$) AS (result agtype);
ERROR: substring() negative values are not supported for offset or length
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', -2147483649, 0)
$$) AS (result agtype);
ERROR: substring() parameter value is out of INT range
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 2147483649, 0)
$$) AS (result agtype);
ERROR: substring() parameter value is out of INT range
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 0, -2147483648)
$$) AS (result agtype);
ERROR: substring() negative values are not supported for offset or length
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 0, -2147483649)
$$) AS (result agtype);
ERROR: substring() parameter value is out of INT range
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 0, 2147483649)
$$) AS (result agtype);
ERROR: substring() parameter value is out of INT range
-- should fail
SELECT * FROM cypher('expr', $$
RETURN substring("123456789", null)
Expand Down
36 changes: 36 additions & 0 deletions regress/sql/expr.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1906,6 +1906,15 @@ $$) AS (results agtype);
SELECT * FROM age_left('123456789', null);
SELECT * FROM age_left('123456789', -1);
SELECT * FROM age_left();
SELECT * FROM cypher('expr', $$
RETURN left('abcdef', -2147483648)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN left('abcdef', -2147483649)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN left('abcdef', 2147483649)
$$) AS (result agtype);
--right()
SELECT * FROM cypher('expr', $$
RETURN right("123456789", 1)
Expand Down Expand Up @@ -1939,6 +1948,15 @@ $$) AS (results agtype);
SELECT * FROM age_right('123456789', null);
SELECT * FROM age_right('123456789', -1);
SELECT * FROM age_right();
SELECT * FROM cypher('expr', $$
RETURN right('abcdef', -2147483648)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN right('abcdef', -2147483649)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN right('abcdef', 2147483649)
$$) AS (result agtype);
-- substring()
SELECT * FROM cypher('expr', $$
RETURN substring("0123456789", 0, 1)
Expand Down Expand Up @@ -1969,6 +1987,24 @@ $$) AS (results agtype);
SELECT * FROM age_substring(null, null, null);
SELECT * FROM age_substring(null, null);
SELECT * FROM age_substring(null, 1);
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', -2147483648, 0)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', -2147483649, 0)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 2147483649, 0)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 0, -2147483648)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 0, -2147483649)
$$) AS (result agtype);
SELECT * FROM cypher('expr', $$
RETURN substring('abcdef', 0, 2147483649)
$$) AS (result agtype);
-- should fail
SELECT * FROM cypher('expr', $$
RETURN substring("123456789", null)
Expand Down
Loading