Skip to content

Conversation

@jrgemignani
Copy link
Contributor

Fixed 2 issues with CALL/YIELD -

  1. If a user defined function was in search_path, the transform_FuncCall
    logic would only find it, if it were part of an extension.

  2. If a function were qualified, the transform_cypher_call_subquery
    logic would mistakenly extract the schema name instead of the
    function name.

NOTE: transform_FuncCall should be reviewed for possible refactor.

Added regression tests.

modified:   src/backend/parser/cypher_clause.c
modified:   src/backend/parser/cypher_expr.c
modified:   regress/expected/cypher_call.out
modified:   regress/sql/cypher_call.sql

@github-actions github-actions bot added master override-stale To keep issues/PRs untouched from stale action labels Sep 9, 2025
Fixed 2 issues with CALL/YIELD -

   1) If a user defined function was in search_path, the transform_FuncCall
      logic would only find it, if it were part of an extension.

   2) If a function were qualified, the transform_cypher_call_subquery
      logic would mistakenly extract the schema name instead of the
      function name.

NOTE: transform_FuncCall should be reviewed for possible refactor.

Added regression tests.

    modified:   src/backend/parser/cypher_clause.c
    modified:   src/backend/parser/cypher_expr.c
    modified:   regress/expected/cypher_call.out
    modified:   regress/sql/cypher_call.sql
@MuhammadTahaNaveed MuhammadTahaNaveed merged commit 94770a6 into apache:master Sep 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

master override-stale To keep issues/PRs untouched from stale action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants