Skip to content

Conversation

@jrgemignani
Copy link
Contributor

@jrgemignani jrgemignani commented Sep 9, 2025

This PR cherry picks the following 3 PRs that were in the master branch, but not in PG17 -

  1. 7aa2d88 fix issue 2205: left doesn't catch overflow (fix issue 2205: left doesn't catch overflow #2207)
  2. 2803ffa Fix issue 2201: unexpected empty string behavior (fix issue 2201: unexpected empty string behavior #2203)
  3. c21f065 Add missing dependency in jdbc driver (Add missing dependency in jdbc driver #2206)

These will be needed for the upcoming advance to 1.6.0 and release of Apache AGE 1.6.0 for PostgreSQL 17

MuhammadTahaNaveed and others added 3 commits September 9, 2025 16:35
- This was also failing CI. The issue is described here gradle/gradle#33950
This PR fixes the issue of some string functions returning NULL
instead of the empty string.

The string functions affected and corrected are -

reverse, toupper, tolower, rtrim, ltrim, trim, right, left, substring,
and replace.

Added additional regression tests. Corrected previous tests.

    modified:   regress/expected/expr.out
    modified:   regress/sql/expr.sql
    modified:   src/backend/utils/adt/agtype.c
Fixed issue 2205 where large int values aren't detected. The
following functions were fixed -

left, right, and substring

    modified:   regress/expected/expr.out
    modified:   regress/sql/expr.sql
    modified:   src/backend/utils/adt/agtype.c

Added regression tests.
@github-actions github-actions bot added PG17 override-stale To keep issues/PRs untouched from stale action labels Sep 9, 2025
@MuhammadTahaNaveed MuhammadTahaNaveed merged commit 0491998 into apache:PG17 Sep 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override-stale To keep issues/PRs untouched from stale action PG17

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants