Skip to content

Conversation

@rafsun42
Copy link
Member

No description provided.

Copy link
Member

@dehowef dehowef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rafsun, these tests look good to me-- Just one thing about the Makefile, make sure the indentation is done correctly, otherwise well done.

@jrgemignani
Copy link
Contributor

@rafsun42 I agree with @dehowef, very well done. Just check the Makefile indentation, as it doesn't look correct, as @dehowef mentioned.

@rafsun42
Copy link
Member Author

@dehowef @jrgemignani Fixed the indentation issue.

@jrgemignani
Copy link
Contributor

Good job @rafsun42 !

@dehowef dehowef merged commit 04fd148 into apache:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants