Barbell graph generation #648
Conversation
|
Please try to verify that your PRs successfully build, without errors, before submitting them; this PR failed. If it did successfully build, please check that your build environment is set up correctly. Additionally, make sure that you follow our coding standard https://age.apache.org/contribution/guide/#code-style-guilde |
markgomer
force-pushed
the
barbell-graph-generation
branch
from
34ca1af to
4513a34
Compare
* Created auxiliary function to get_next_val_internal; * Currently creates a bridge of no vertexes between graphs, will be implemented next.
markgomer
force-pushed
the
barbell-graph-generation
branch
from
4513a34 to
654dadf
Compare
|
Turns out that I had changed the return type of the function I changed the return type of the functions to |
|
|
@markgomer Please verify that your code follows our coding standards. |
|
@jrgemignani I don't see where the code doesn't match the standards. I've read the documentation through. Could you point me to what I have to fix? |
There are minor indentation issues and a few if/else statements that are missing braces {}. All if/else statements are required to have braces, even if there is only one line. I know that it is a bit confusing as some of the code doesn't follow that standard, but that code predates the adoption of braces for all if/else statements. |
|
@markgomer Additionally, PG_FUNCTION_INFO_V1 is incorrectly placed. There are 2, one from this commit, the other not. If you could please fix both, that would be great. |
* moved PG_FUNCTION_INFO_V1(age_create_barbell_graph) next to age_create_barbell_graph function; * added brackets to if/else conditions if just one line; * moved get_nextval_internal auxiliary function to the beggining of the file.
|
@jrgemignani, thank you for your time. I have fixed what you pointed. Please let me know if there's anything else left for fixing. |
|
I'll investigate the issue with the test. I'm not sure what happened, since I didn't change anything that would break the code since the last test which passed. |
src/backend/utils/graph_generation.c
Outdated
| #include "utils/load/ag_load_labels.h" | ||
|
|
||
|
|
||
| PG_FUNCTION_INFO_V1(create_complete_graph); |
There was a problem hiding this comment.
This is incorrectly located - it needs to precede the function, not be at the top of the file.
src/backend/utils/graph_generation.c
Outdated
|
|
||
|
|
||
| PG_FUNCTION_INFO_V1(create_complete_graph); | ||
| PG_FUNCTION_INFO_V1(age_create_barbell_graph); |
There was a problem hiding this comment.
This is incorrectly located - it needs to precede the function, not be at the top of the file.
|
@markgomer I overlooked that you need to have regression tests created to test this feature and added to the PR. Could you please create a PR for regression tests for this feature. |
Of course @jrgemignani, I'm already working on that. |
|
@markgomer Thank you! Next time, though, the regression tests need to be included in the PR with the feature or bug fix. |
* Added function to create a Barbell Graph * Created auxiliary function to get_next_val_internal; * Currently creates a bridge of no vertexes between graphs, will be implemented next. * Added signature to age_create_barbell_graph * Moved bracket to next line to macth code standards * Fixed patterns to match code standards * moved PG_FUNCTION_INFO_V1(age_create_barbell_graph) next to age_create_barbell_graph function; * added brackets to if/else conditions if just one line; * moved get_nextval_internal auxiliary function to the beggining of the file.
* Added function to create a Barbell Graph * Created auxiliary function to get_next_val_internal; * Currently creates a bridge of no vertexes between graphs, will be implemented next. * Added signature to age_create_barbell_graph * Moved bracket to next line to macth code standards * Fixed patterns to match code standards * moved PG_FUNCTION_INFO_V1(age_create_barbell_graph) next to age_create_barbell_graph function; * added brackets to if/else conditions if just one line; * moved get_nextval_internal auxiliary function to the beggining of the file. Conflicts: src/backend/utils/graph_generation.c Co-authored-by: John Gemignani <jrgemignani@gmail.com>
2 participants
On
src/backend/utils/graph_generation.c:Added function to create a Barbell Graph
Modified function create_complete_graph to return the Oidof the created graph;will be implemented next.
On
age--1.2.0.sql:Reflect modifications in graph_generation.c
Changed return type of create_complete_graph;Resolves #275;