Fix property constraints against resolved variables (#724) #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have reviewed these changes with John and have tested them and they look good and align with the expected behavior that AGE should have |
Fixed an issue where an already resolved variable, when used for a property constraint, errored out. See apache#724 for more details. This is the second part of the fix for the match property constraint bug regarding variable reuse. The prior fix addressed clause-to-clause, this fix addresses within a clause. Adjusted and added additional regression tests. Co-authored-by: Dehowe Feng <dehowefeng@gmail.com>
jrgemignani
force-pushed
the
fix_property_constraints_2
branch
from
f0a1318 to
0c4a985
Compare
Contributor
Author
|
@dehowef Updated PR to include label checking and additional regression tests. |
Member
|
Looked over the additional regression tests, and they look good to me. |
dehowef
added a commit
to dehowef/age
that referenced
this pull request
Mar 23, 2023
Fixed a segmentation fault edge case regarding invalid labels being used in a repeated variable.
jrgemignani
pushed a commit
that referenced
this pull request
Mar 23, 2023
jrgemignani
added a commit
that referenced
this pull request
Mar 24, 2023
Fixed an issue where an already resolved variable, when used for a property constraint, errored out. See #724 for more details. This is the second part of the fix for the match property constraint bug regarding variable reuse. The prior fix addressed clause-to-clause, this fix addresses within a clause. Adjusted and added additional regression tests. Co-authored-by: Dehowe Feng <dehowefeng@gmail.com>
jrgemignani
pushed a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where an already resolved variable, when used for
a property constraint, errored out. See issue #724 for more details.
This is the second part of the fix for the match property constraint
bug regarding variable reuse. The prior fix addressed clause-to-clause,
this fix addresses within a clause.
Adjusted and added additional regression tests.
Co-authored-by: Dehowe Feng dehowefeng@gmail.com