Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 23, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:CLI area:dev-tools area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues labels Aug 23, 2020
@turbaszek
Copy link
Member

I'm afraid that this will require more changes due to cyclic imports :<

@potiuk potiuk force-pushed the make-dagrun-pylint-compatible branch from d703d0c to 6ad7193 Compare August 24, 2020 19:33
@potiuk potiuk changed the title Make DagRun and Dag pylint-compatible [WIP] Make DagRun and Dag pylint-compatible Aug 24, 2020
@potiuk
Copy link
Member Author

potiuk commented Aug 24, 2020

I want to rebase that one on top of #10499 to see if the cyclic dependencies problem will be fixed,

@potiuk potiuk force-pushed the make-dagrun-pylint-compatible branch from 6ad7193 to d6f7d4a Compare August 24, 2020 22:27
@potiuk
Copy link
Member Author

potiuk commented Aug 24, 2020

@potiuk
Copy link
Member Author

potiuk commented Aug 24, 2020

It will likely fail with cyclic impots we will have to resolve though :(

@potiuk
Copy link
Member Author

potiuk commented Aug 24, 2020

airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.models.dag -> airflow.operators.subdag_operator) (cyclic-import)
airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.models -> airflow.models.dag -> airflow.sensors.external_task_sensor) (cyclic-import)
airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.models -> airflow.models.dagbag -> airflow.models.dag -> airflow.sensors.external_task_sensor -> airflow.operators.dummy_operator) (cyclic-import)
airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.api.common.experimental.get_task_instance -> airflow.models -> airflow.models.dag -> airflow.operators.subdag_operator) (cyclic-import)
airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.models -> airflow.models.dagbag -> airflow.models.serialized_dag -> airflow.serialization.serialized_objects -> airflow.models.dag -> airflow.sensors.external_task_sensor -> airflow.operators.dummy_operator) (cyclic-import)
airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.models -> airflow.models.dagbag -> airflow.models.serialized_dag -> airflow.models.dag -> airflow.sensors.external_task_sensor -> airflow.operators.dummy_operator) (cyclic-import)
airflow/providers/amazon/aws/example_dags/example_emr_job_flow_automatic_steps.py:1:0: R0401: Cyclic import (airflow.api.common.experimental -> airflow.models -> airflow.models.dag -> airflow.operators.subdag_operator -> airflow.api.common.experimental.get_task_instance) (cyclic-import)

@potiuk
Copy link
Member Author

potiuk commented Aug 24, 2020

Tomorrow :)

@potiuk potiuk force-pushed the make-dagrun-pylint-compatible branch from d6f7d4a to 464daa5 Compare August 24, 2020 23:08
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 12, 2020
@mik-laj mik-laj removed the area:API Airflow's REST/HTTP API label Oct 19, 2020
@stale stale bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 19, 2020
@potiuk potiuk closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI area:dev-tools area:Scheduler including HA (high availability) scheduler area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants