Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Nov 19, 2020

The tests passed on #12459 as it only ran tests for Py3.6.

When it was merged to master, tests failed on Py3.8. This commit should fix all failing tests on Py3.8


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil added the full tests needed We need to run full set of tests for this PR to merge label Nov 19, 2020
@kaxil kaxil requested a review from ashb November 19, 2020 12:44
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 19, 2020
@kaxil kaxil requested review from XD-DENG and potiuk November 19, 2020 13:40
@kaxil
Copy link
Member Author

kaxil commented Nov 19, 2020

Tests on Python 3.8 are green

@ashb ashb merged commit 5ffb7f4 into apache:master Nov 19, 2020
@ashb ashb deleted the fix-failing-tests branch November 19, 2020 13:49
@potiuk
Copy link
Member

potiuk commented Nov 19, 2020

An interesting one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants