-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Hide ToC from the Apache Airflow doc main page #12589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide ToC from the Apache Airflow doc main page #12589
Conversation
Hide the ToC from being displayed when the the index.rst file in the Apache Airflow docs is rendered. This will improve user experience and prevent repetition of what has already been displayed on the sidebar.
kaxil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now this looks good, however I think it would be good to have a separate page for just "TOC/Index"
|
The PR is ready to be merged. No tests are needed! |
|
The whole point is the ToC is in the sidebar of every page. |
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
The problem with that is the sidebar hides nesting until you click on the level above it. So to have a TOC that shows all the index would still be better, though on a separate page. Definitely not on the main page. Example: https://airflow.readthedocs.io/en/stable/ https://airflow.readthedocs.io/en/stable/howto/index.html https://airflow.readthedocs.io/en/stable/howto/operator/gcp/index.html |
|
What do you think about moving the entire content to a separate sub-page with the title "Overview" and leaving the only a table of contents in the index.rst file? |
|
Whops, just saw your comment as I hit merge @mik-laj, sorry! |
|
I think index.html shouldn't be the index page, but some kind of welcome/intro -- it's often the first place people land, and going straight to "here's a load of links" isn't very helpful. I have no problem with a separate contents page. |
|
What do you think about having index.html to have a table of contents in TOC, but to give a liink to overview.html on s.apache.org/aiirflow-docs ? Do you know how to go to index.html while you are at tutorial.html? |
This reverts commit ce91991.




Fixes #12554 - #12561 addressed this by limiting the depth, but we can do better.
Before
After
Hide the ToC from being displayed when the
the index.rst file in the Apache Airflow docs is rendered.
This will improve user experience and prevent repetition of what has
already been displayed on the sidebar.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.