-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Change constraints to use pipcheck #12601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@turbaszek - this is a change that uses the deps synced so that the |
|
Once we fix all the tests here, we can fix them for master! |
|
manually |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
We are trying to have a separate branch and check where we can tests latest constraints upgraded and run tests there. before we share thee constraints with thee master branch. |
|
And runnning pip check in CI pipeline there. |
Isn't the |
e92575f to
bc9ea30
Compare
No. It's more than that. Pip always (for a very long time) had conflicts between different versions of our dependencies. PIP does not always solve them. What we did with constraints we simply captured what pip install does with the current setup.py files. The passing tests, do not mean that there is no conflict between dependencies. The constraints mechanism did not solve those conflict - this something we are trying to do right now with Tomek. It simply captured the set of constraints that was the result of pip install. Pip check simply fails if there are version conflicts and shows them. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Passing test is not the same as passing |
bc9ea30 to
bb1fe0c
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
OK @turbaszek -> this PR has now all the constraints updated and pip check should not fail, however we have some failures resulting from the azure storage Blob missing. I think it's a missing implicit dependency and will try to fix it - but in the meantime you can rebase your Pip-check change on top of mine (maybe just add it here) |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
Got it, would be a good change with the new PIP resolver, can you add the summary of this to PR descriptions for future readers too, please |
This PR is mostly with trying it out and running tests. we will create separate PR from that later on when we actually figure out all that needs to be done |
|
I mark it as Draft for now :) |
|
@turbaszek -> Seems it worked and we can get a working pip-check set of deps :). At least for 3.6. I am going to mark it as full-test-needed and re-push. |
1e338c0 to
61e1d52
Compare
61e1d52 to
5ef5bef
Compare
|
Deleting it and the "constraints-pipcheck" branch as we have a good "regular" solution with "upgrade to latest dependencies" label in #12635 |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.