Skip to content

Change the format for sha512 sum for releases #12867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaxil merged 1 commit into from
Dec 6, 2020
Merged

Change the format for sha512 sum for releases #12867

kaxil merged 1 commit into from
Dec 6, 2020

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Dec 6, 2020

closes #12832

This format is popular and supported by tools like Ansible.

❯ sha512sum ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
953d3c04ee6fd2fa96e126750e642fc0872add96d180901440a91bd61c494a711b48836c634d93dcb181006935772556d5b4426671bf1a638f0a0698b51b119f  ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz

vs

❯ gpg --print-md SHA512 ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz:
953D3C04 EE6FD2FA 96E12675 0E642FC0 872ADD96 D1809014 40A91BD6 1C494A71 1B48836C
 634D93DC B1810069 35772556 D5B44266 71BF1A63 8F0A0698 B51B119F

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil
Change the format for sha512 sum for releases
a4487a8 
closes apache#12832

This format is popular and supported by tools like Ansible.

```
❯ sha512sum ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
953d3c04ee6fd2fa96e126750e642fc0872add96d180901440a91bd61c494a711b48836c634d93dcb181006935772556d5b4426671bf1a638f0a0698b51b119f  ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
```

vs

```
❯ gpg --print-md SHA512 ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz:
953D3C04 EE6FD2FA 96E12675 0E642FC0 872ADD96 D1809014 40A91BD6 1C494A71 1B48836C
 634D93DC B1810069 35772556 D5B44266 71BF1A63 8F0A0698 B51B119F
```
@kaxil kaxil requested review from Fokko, XD-DENG, ashb and potiuk December 6, 2020 22:39
@kaxil kaxil mentioned this pull request Dec 6, 2020
Closed
XD-DENG
XD-DENG reviewed Dec 6, 2020
View reviewed changes
Copy link
Member

@XD-DENG XD-DENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another usage of gpg --print-md SHA512 in dev/README_RELEASE_PROVIDER_PACKAGES.md. Shall it be updated as well?

@kaxil
Copy link
Member Author

kaxil commented Dec 6, 2020

There is another usage of gpg --print-md SHA512 in dev/README_RELEASE_PROVIDER_PACKAGES.md. Shall it be updated as well?

Looks like that was a separate issue, fixed it here: #12869

@noelmcloughlin
Copy link
Contributor

noelmcloughlin commented Dec 6, 2020

Supported by Salt too.

@github-actions
Copy link

github-actions bot commented Dec 6, 2020

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 6, 2020
@kaxil kaxil merged commit a00f250 into apache:master Dec 6, 2020
@kaxil kaxil deleted the shasum branch December 6, 2020 23:46
@XD-DENG
Copy link
Member

XD-DENG commented Dec 7, 2020

Hi @kaxil , what I meant was actually this part instead https://github.com/apache/airflow/blob/a4487a82cf7f399fa0cc20a1a09c1b1b329927d7/dev/README_RELEASE_PROVIDER_PACKAGES.md#sha512-check

May not be relevant necessarily, but you may help double-check.

kaxil added a commit to astronomer/airflow that referenced this pull request Dec 7, 2020
@kaxil
Update commands to verify singature and shasum for Providers
add80b0 
This commit ports changes from apache#12869 & apache#12867 to Providers doc
@kaxil kaxil mentioned this pull request Dec 7, 2020
Merged
@kaxil
Copy link
Member Author

kaxil commented Dec 7, 2020

Hi @kaxil , what I meant was actually this part instead https://github.com/apache/airflow/blob/a4487a82cf7f399fa0cc20a1a09c1b1b329927d7/dev/README_RELEASE_PROVIDER_PACKAGES.md#sha512-check

May not be relevant necessarily, but you may help double-check.

Oh yeah -- missed it -- Created #12886 to update that too

XD-DENG pushed a commit that referenced this pull request Dec 7, 2020
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
2c70ac4 
This commit ports changes from #12869 & #12867 to Providers doc
@ashb
Copy link
Member

ashb commented Dec 7, 2020

I've been meaning to do this for ages. ✨

kaxil added a commit that referenced this pull request Mar 10, 2021
@kaxil
Change the format for sha512 sum for releases (#12867)
8e4ea66 
closes #12832

This format is popular and supported by tools like Ansible.

```
❯ sha512sum ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
953d3c04ee6fd2fa96e126750e642fc0872add96d180901440a91bd61c494a711b48836c634d93dcb181006935772556d5b4426671bf1a638f0a0698b51b119f  ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
```

vs

```
❯ gpg --print-md SHA512 ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz:
953D3C04 EE6FD2FA 96E12675 0E642FC0 872ADD96 D1809014 40A91BD6 1C494A71 1B48836C
 634D93DC B1810069 35772556 D5B44266 71BF1A63 8F0A0698 B51B119F
```

(cherry picked from commit a00f250)
kaxil added a commit that referenced this pull request Mar 10, 2021
@kaxil
Change the format for sha512 sum for releases (#12867)
583cecc 
closes #12832

This format is popular and supported by tools like Ansible.

```
❯ sha512sum ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
953d3c04ee6fd2fa96e126750e642fc0872add96d180901440a91bd61c494a711b48836c634d93dcb181006935772556d5b4426671bf1a638f0a0698b51b119f  ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
```

vs

```
❯ gpg --print-md SHA512 ../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz
../airflow-dev/1.10.14rc3/apache-airflow-1.10.14rc3-bin.tar.gz:
953D3C04 EE6FD2FA 96E12675 0E642FC0 872ADD96 D1809014 40A91BD6 1C494A71 1B48836C
 634D93DC B1810069 35772556 D5B44266 71BF1A63 8F0A0698 B51B119F
```

(cherry picked from commit a00f250)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
af0b1e9 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
4dee6c3 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
115e8da 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 27, 2021
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
a42b70d 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 10, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
185bd6d 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
cdf6912 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 7, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
c126202 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
7598009 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
39aa98d 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
8fa5ae0 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
bdedc47 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
0a3e9ee 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
c45ac36 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
@sebastianliebscher sebastianliebscher mentioned this pull request Oct 9, 2023
Merged
9 tasks
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
00584aa 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
3be064e 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2024
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
735ec85 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2024
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
1905723 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 1, 2025
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
dd74c2c 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 21, 2025
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
b2bb3ef 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2025
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
b40582c 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 15, 2025
@kaxil
Update commands to verify singature and shasum for Providers (#12886)
a803185 
This commit ports changes from apache/airflow#12869 & apache/airflow#12867 to Providers doc

GitOrigin-RevId: 2c70ac41af8bcf2a7af329a153915f5b2706708a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XD-DENG XD-DENG XD-DENG left review comments

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb

@Fokko Fokko Awaiting requested review from Fokko

Assignees

No one assigned

Labels

area:dev-tools okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Source hash apache-airflow-1.10.13-bin.tar.gz.sha512 format is invalid

5 participants

@kaxil @noelmcloughlin @XD-DENG @ashb @potiuk