Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Dec 10, 2020

This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

UPDATING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description here is a bit inaccurate.

I understand this part is referred from https://github.com/apache/airflow/blob/master/docs/apache-airflow/upgrading-to-2.rst but a difference here is: in 1.10.14, users will get a deprecation warning if they use the "old" commands, but they don't get a hard failure (they don't have to make changes in 1.10.14).

Copy link
Member

@XD-DENG XD-DENG Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to change to

The Airflow CLI in 1.10.14 has been changed to be in line with CLI in 2.0. The 1.10.* style CLI will still work, but users will get deprecation warning messages to be reminded to upgrade their scripts. This is is part of 1.10.14's 'bridge' role.

UPDATE: Your latest commit suffices

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 10, 2020
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase
@kaxil kaxil force-pushed the 1.10.13-changelog branch from d9bfd84 to 9616ddc Compare December 10, 2020 20:52
@kaxil kaxil merged commit 969d3ea into apache:master Dec 10, 2020
@kaxil kaxil deleted the 1.10.13-changelog branch December 10, 2020 20:52
potiuk pushed a commit that referenced this pull request Dec 13, 2020
This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase

(cherry picked from commit 969d3ea)
kaxil added a commit that referenced this pull request Jan 21, 2021
This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase

(cherry picked from commit 969d3ea)
kaxil added a commit that referenced this pull request Jan 22, 2021
This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase

(cherry picked from commit 969d3ea)
kaxil added a commit that referenced this pull request Jan 22, 2021
This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase

(cherry picked from commit 969d3ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants