Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 24, 2020

Since K8S tests use Airflow CLI (via Helm Chart) we should
also run the K8S tests when CLI changes.

Fixes #12780


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Since K8S tests use Airflow CLI (via Helm Chart) we should
also run the K8S tests when CLI changes.

Fixes apache#12780
@potiuk
Copy link
Member Author

potiuk commented Dec 24, 2020

@ashb - avoid problems similar to what we had in #12725

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 24, 2020
@potiuk potiuk merged commit e2bfac9 into apache:master Dec 24, 2020
@potiuk potiuk deleted the run-k8s-tests-on-cli-changes branch December 24, 2020 14:48
@potiuk potiuk added this to the Airflow 2.0.1 milestone Jan 2, 2021
kaxil pushed a commit that referenced this pull request Jan 21, 2021
Since K8S tests use Airflow CLI (via Helm Chart) we should
also run the K8S tests when CLI changes.

Fixes #12780

(cherry picked from commit e2bfac9)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Apr 23, 2021
Since K8S tests use Airflow CLI (via Helm Chart) we should
also run the K8S tests when CLI changes.

Fixes apache#12780

(cherry picked from commit e2bfac9)
(cherry picked from commit ea5af5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

K8S were not run on cli change

2 participants