When "full tests needed" label is present, run all tests #13538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This label can be set manually, and the expectation is that it would run all tests, but in some cases for PRs that don't touch code, it would still skip most of the matrix and run minimal static checks only. This changes the behaviour so that if the label is found it will run all tests no matter what files have been changed -- making the label name more true :)
kaxil
approved these changes
Jan 7, 2021
potiuk
approved these changes
Jan 7, 2021
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice. Indeed that was not forced but we can add it.
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
This label can be set manually, and the expectation is that it would run all tests, but in some cases for PRs that don't touch code, it would still skip most of the matrix and run minimal static checks only. This changes the behaviour so that if the label is found it will run all tests no matter what files have been changed -- making the label name more true :) (cherry picked from commit ef2123c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This label can be set manually, and the expectation is that it would run
all tests, but in some cases for PRs that don't touch code, it would
still skip most of the matrix and run minimal static checks only.
This changes the behaviour so that if the label is found it will run all
tests no matter what files have been changed -- making the label name
more true :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.