Add classic installation scripts for additional tools #13587
Conversation
mik-laj
force-pushed
the
install-scripts
branch
from
ba50a65 to
5020cf1
Compare
turbaszek
left a comment
turbaszek
left a comment
There was a problem hiding this comment.
Lovely! I always had install_imcat.sh in files/ 😄
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
❤️ Much better than dind approach!
mik-laj
changed the title
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
mik-laj
force-pushed
the
install-scripts
branch
2 times, most recently
from
500a273 to
53e0fb0
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
|
#13589 should fix it. |
mik-laj
force-pushed
the
install-scripts
branch
from
37ef2d2 to
d16f6c0
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
(cherry picked from commit 1d1ea52)
3 participants
Docker in docker sometimes causes problems, especially for Mac OS users, so I prepared scripts that install these tools in a classic way in the
/files/directory. This way, they still remain installed after restarting the environment, but Docker is not used, so we have more stability and less complexity.These scripts are self-contained (ie they don't use global variables or other scripts) to keep them simple.
CC: @ephraimbuddy @TobKed @michalslowikowski00
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.