Fix flower ingress annotations in chart #13615
Conversation
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
|
Can you please rebase @FloChehab ? We have some serious CI slow-downs (we are working on it) but this leads to some master broken more often than we would like to have. Apologies. Rebasing should fix the problem. |
FloChehab
force-pushed
the
fix-flower-ingress-annotations
branch
from
b665654 to
37cbc36
Compare
Done. |
FloChehab
force-pushed
the
fix-flower-ingress-annotations
branch
from
37cbc36 to
79a3032
Compare
apache#12010 introduced a small bug in the way annotations are handled for the flower ingress. A test have been added to prevent this from occuring againg. Also more conditionnals have been added to the flower-ingress.yaml file to make it compatible with schema validation.
FloChehab
force-pushed
the
fix-flower-ingress-annotations
branch
from
79a3032 to
6aa2db7
Compare
|
Hello @potiuk, I performed another rebase today, we should be good to merge! |
|
Thanks! |
4 participants
Hello,
A small follow up to #12010.
#12010 introduced
a small bug in the way annotations are handled for the
flower ingress.
A test have been added to prevent this from occuring againg.
Also more conditionals have been added to the
flower-ingress.yaml file to make it compatible with schema
validation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.