Support annotations for the flower service in the chart #13616
Conversation
Simple commit that adds the ability to add annotations to the flower service in the chart. Docs and tests updated accordingly.
|
Hello @mik-laj , this PR is good start towards what you were describing in #12010 (comment) . |
|
I wonder if we should review all objects and standardize support for annotations. As you can see this annotation support is being added in several PRs for different objects, and I guess it won't be hard to do this for all objects. Are you interested in this? |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
Yeah I can look into that. Maybe we should create an issue for this so that we agree on the how (terminology, objects, location in the values.yaml) before starting the dev? Wdyt ? |
|
@FloChehab the idea sounds good to me. the new issue allows us to discuss freely. |
|
Closing in favor of #13643. |
2 participants
Hello,
This is simple PR that adds the ability to add annotations
to the flower service in the chart.
Docs and tests updated accordingly.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.