Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 12, 2021

When testing locally generated providers, we should skip installing
them from PyPI because some providers might be added which are
not yet in PyPI.

There was a mistake in copy&pasted workflow which caused that
the providers have been first installed from PyPI and then
uninstalled, but in case of a new providers added, this
caused a failure as newly added providers failed to install
from PyPI.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested review from kaxil and mik-laj January 12, 2021 10:20
@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2021

CC: @kanthi

@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2021

Testing it here: https://github.com/potiuk/airflow/actions/runs/479945895 when it passes the provider test steps I will merge it

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 12, 2021
@kaxil
Copy link
Member

kaxil commented Jan 12, 2021

Testing it here: https://github.com/potiuk/airflow/actions/runs/479945895 when it passes the provider test steps I will merge it

hmm weird -- that one failed with "Error: Failed to resolve action download info."

When testing locally generated providers, we should skip installing
them from PyPI because some providers might be added which are
not yet in PyPI.

There was a mistake in copy&pasted workflow which caused that
the providers have been first installed from PyPI and then
uninstalled, but in case of a new providers added, this
caused a failure as newly added providers failed to install
from PyPI.
@potiuk potiuk force-pushed the fix-installing-providers-from-sources-while-testing-provider-packages branch from 217d04a to e94f1d1 Compare January 12, 2021 12:36
@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2021

Ah yeah. That was cancelled as I re-pushed after merging yet another fix for my and Ash's cross-merged submodule/workflow split commits #13633

@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2021

@potiuk potiuk merged commit 3d53863 into apache:master Jan 12, 2021
@potiuk potiuk deleted the fix-installing-providers-from-sources-while-testing-provider-packages branch January 12, 2021 14:25
kaxil pushed a commit that referenced this pull request Jan 21, 2021
When testing locally generated providers, we should skip installing
them from PyPI because some providers might be added which are
not yet in PyPI.

There was a mistake in copy&pasted workflow which caused that
the providers have been first installed from PyPI and then
uninstalled, but in case of a new providers added, this
caused a failure as newly added providers failed to install
from PyPI.

(cherry picked from commit 3d53863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants