Add Snowflake provider to boring cyborg automation #14432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Feb 24, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
turbaszek
force-pushed
the
add-snowflake-to-cyborg
branch
from
858c195 to
13a792a
Compare
Member
Author
👀 |
Member
|
Rebase. I merged a fix already. |
kaxil
approved these changes
Feb 25, 2021
turbaszek
force-pushed
the
add-snowflake-to-cyborg
branch
2 times, most recently
from
3cdc5c2 to
1e916b8
Compare
Member
Author
|
I rebased 3 times and the problem still occurs. We can probably merge this change but it would be good to know why there's an issue |
Member
|
This is the reason: #14451 -> I forgot to update PATH in basic_static_checks.sh and it is executed only sometimes, so I have not caught it before. |
Member
|
Now rebase should help :). |
turbaszek
force-pushed
the
add-snowflake-to-cyborg
branch
from
1e916b8 to
1038c4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.