Fix pylint pre-commit checks when only todo files are changed #14453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we specified `--rcfile` as an argument to the script, the check for "no files" was failing and pylint was being run with no files, resulting in an error.
ashb
commented
Feb 25, 2021
| name: Run pylint for main code | ||
| language: system | ||
| entry: "./scripts/ci/pre_commit/pre_commit_pylint.sh --rcfile pylintrc" | ||
| entry: "./scripts/ci/pre_commit/pre_commit_pylint.sh" |
Member
Author
There was a problem hiding this comment.
We don't need to specify this, pylintrc is one of the defaults places it looks https://github.com/PyCQA/pylint/blame/41d70221cdce96a209a479e349bdb70180bb5e8e/pylint/config/find_default_config_files.py#L27-L63
sfc-gh-jpotiuk
approved these changes
Feb 25, 2021
|
Silly me :( |
Member
Author
|
Easy mistake to make |
|
|
||
| build_images::rebuild_ci_image_if_needed | ||
|
|
||
| # Bug: Pylint only looks at PYLINTRC if it can't find a file in the _default_ |
Member
Author
There was a problem hiding this comment.
Turns out it's even more annoying that that. PYLINTRC is an additional pylint file.
|
I wish we could finally get rid of the TODOs .. |
kaxil
approved these changes
Feb 25, 2021
potiuk
pushed a commit
that referenced
this pull request
Mar 3, 2021
Because we specified `--rcfile` as an argument to the script, the check for "no files" was failing and pylint was being run with no files, resulting in an error. (cherry picked from commit ab72b05)
potiuk
pushed a commit
that referenced
this pull request
Mar 3, 2021
Because we specified `--rcfile` as an argument to the script, the check for "no files" was failing and pylint was being run with no files, resulting in an error. (cherry picked from commit ab72b05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we specified
--rcfileas an argument to the script, the checkfor "no files" was failing and pylint was being run with no files,
resulting in an error.
This bug was introduced in #14332
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.