Restore correct terminal with to interactive breeze usage#14579
Merged
ashb merged 2 commits intoapache:masterfrom Mar 4, 2021
Merged
Restore correct terminal with to interactive breeze usage#14579ashb merged 2 commits intoapache:masterfrom
ashb merged 2 commits intoapache:masterfrom
Conversation
Member
Author
|
The |
potiuk
approved these changes
Mar 3, 2021
Member
|
Yep. It's tricky with 'Posix-ish' level of support on MacOS |
Member
Author
|
Just updating brew on my mac laptop to test out a fix. |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
The change to redirect all breeze output to a file had the effect of making stdin no longer a TTY, which meant that the docker container had a fixed with of 80 columns. The fix is to replace the use of `tee` with `scripts`, which does what we want -- captures stdout+stderr, but makes the running program believe that it is still attached to a terminal (if it ever was).
ashb
force-pushed
the
restore-correct-terminal-width-breeze
branch
from
58ef856 to
6a3ce31
Compare
Member
Author
|
@kaxil Updated -- could you confirm this works for you on OSX please? |
Member
Author
|
Will merge without CI -- this doesn't affect them anyway. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 15, 2021
The BASH variable introduced in apache#14579 is not set when the main shell is zsh on MacOS (which is the default) this PR changes it so that the output of `command -v bash` is used instead. Fixes apache#14754
potiuk
added a commit
that referenced
this pull request
Mar 15, 2021
potiuk
pushed a commit
that referenced
this pull request
Mar 23, 2021
The change to redirect all breeze output to a file had the effect of making stdin no longer a TTY, which meant that the docker container had a fixed with of 80 columns. The fix is to replace the use of `tee` with `scripts`, which does what we want -- captures stdout+stderr, but makes the running program believe that it is still attached to a terminal (if it ever was). (cherry picked from commit 4c1e3c8)
ashb
added a commit
that referenced
this pull request
Apr 15, 2021
The change to redirect all breeze output to a file had the effect of making stdin no longer a TTY, which meant that the docker container had a fixed with of 80 columns. The fix is to replace the use of `tee` with `scripts`, which does what we want -- captures stdout+stderr, but makes the running program believe that it is still attached to a terminal (if it ever was). (cherry picked from commit 4c1e3c8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to redirect all breeze output to a file (#14470) had the effect of making stdin no longer a TTY, which meant that the docker container had a fixed with of 80 columns.
The fix is to replace the use of
teewithscripts, which does what we want -- captures stdout+stderr, but makes the running program believe that it is still attached to a terminal (if it ever was).Tested with
./breeze -n shell -- -c 'set -x; [[ $(tput cols) -gt 80 ]]'