Skip to content

[AIRFLOW-53] Add CLI DagBag loading stats option to list_dags subcommand#1468

Merged
mistercrunch merged 1 commit intomasterfrom
list_dags_report
May 6, 2016
Merged

[AIRFLOW-53] Add CLI DagBag loading stats option to list_dags subcommand#1468
mistercrunch merged 1 commit intomasterfrom
list_dags_report

Conversation

@mistercrunch
Copy link
Member

Please accept this PR that addresses the following issues:

Also shut off the logging.debug call as it was way too verbose in the context of unitests as they load DagBags over and over.

task_num=sum([o.dag_num for o in stats]),
table=pprinttable(stats),
)
logging.debug(dagbag_stats)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was litterring the travis stdout like crazy

@aoen
Copy link
Contributor

aoen commented May 5, 2016

LGTM

@r39132
Copy link
Contributor

r39132 commented May 5, 2016

Please squash commits.

@criccomini
Copy link
Contributor

Squash and add AIRFLOW-53 to the beginning of commit string.

@mistercrunch
Copy link
Member Author

Should we re-enable the new and amazing rebase-squash-merge button in this repo? I'm missing my admin privileges. I can't even check if the master branch is still protected after the move...

Will squash for now.

Adding DagBag stats report to CLI's list_dags

Removing logging call in favor of CLI, on-demend based approach

Addressing Dan's feedback
@mistercrunch mistercrunch merged commit d2f3fb4 into master May 6, 2016
yiqingj pushed a commit to yiqingj/airflow that referenced this pull request May 27, 2016
* master:
  AIRFLOW-92 Avoid unneeded upstream_failed session closes apache#1485
  AIRFLOW-52 Warn about overwriting tasks in a DAG
  Add logic to lock DB and avoid race condition
  Handle queued tasks from multiple jobs/executors
  [AIRFLOW-80] Move example_twitter dag to contrib/example_dags as it requires hive
  [AIRFLOW-75] Fix bug in S3 config file parsing
  Use getfqdn to make sure urls are fully qualified
  [AIRFLOW-52] Fix bottlenecks when working with many tasks
  Add bulk_dump abstract method to DbApiHook (apache#1471)
  Fix corner case with joining processes/queues (apache#1473)
  [AIRFLOW-53] Adding DagBag stats report to CLI's list_dags (apache#1468)
@asfgit asfgit deleted the list_dags_report branch January 4, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants