Skip to content

Fix tests in tests/www/test_views.py #14719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Mar 11, 2021
Merged

Fix tests in tests/www/test_views.py #14719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/www/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2790,9 +2790,9 @@ def test_trigger_dag_form_origin_url(self, test_origin, expected_origin):
# https://github.com/python/cpython/pull/24297/files
# Check if tests are running with a Python version containing the above fix
# where ";" is removed as a separator
if parse_qsl(";a=b") != [(';a', 'b')]:
expected_url = expected_origin.replace("%3B", "&")
expected_url += "="
if parse_qsl(";a=b") != [(';a', 'b')] and ";" in test_origin:
expected_origin = expected_origin.replace("%3B", "&")
expected_origin += "="

resp = self.client.get(f'trigger?dag_id={test_dag_id}&origin={test_origin}')
self.check_content_in_response(
Expand Down Expand Up @@ -3341,7 +3341,7 @@ def test_get_safe_url(self, test_url, expected_url, mock_url_for):
# https://github.com/python/cpython/pull/24297/files
# Check if tests are running with a Python version containing the above fix
# where ";" is removed as a separator
if parse_qsl(";a=b") != [(';a', 'b')]:
if parse_qsl(";a=b") != [(';a', 'b')] and ";" in test_url:
expected_url = expected_url.replace("%3B", "&")
expected_url += "="

Expand Down