Skip to content

Conversation

@jlowin
Copy link
Member

@jlowin jlowin commented Jun 1, 2016

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

185:

  • Fix bug with empty versions list

187:

  • Add command to setup_git_remotes
  • Add guard for running PR tool in a branch with uncommitted changes
  • Add option to edit squash commit message
  • Message styling for clarity

@jlowin jlowin force-pushed the pr-tool-5 branch 3 times, most recently from c460e25 to 095c300 Compare June 1, 2016 19:35
dev/airflow-pr Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: puerly typo, and newline seems erroneous here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@criccomini
Copy link
Contributor

LGTM just a couple of nits

- Add command to setup_git_remotes
- Add guard for running PR tool in a branch with uncommitted changes
- Add option to edit squash commit message
- Message styling for clarity
- Improved error messages for PR Tool problems
@asfgit asfgit merged commit d0d54e8 into apache:master Jun 2, 2016
asfgit pushed a commit that referenced this pull request Jun 2, 2016
@jlowin jlowin deleted the pr-tool-5 branch June 2, 2016 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants