[AIRFLOW-111] DAG concurrency is not honored#1579
Closed
shenghuy wants to merge 2 commits intoapache:masterfrom
Closed
[AIRFLOW-111] DAG concurrency is not honored#1579shenghuy wants to merge 2 commits intoapache:masterfrom
shenghuy wants to merge 2 commits intoapache:masterfrom
Conversation
Current coverage is 67.91%@@ master #1579 diff @@
==========================================
Files 116 116
Lines 8292 8296 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5632 5634 +2
- Misses 2660 2662 +2
Partials 0 0
|
Contributor
Contributor
|
Thanks for the cc @bolkedebruin This should already be covered by #1525 (I'm waiting on a few other big PRs to the core to settle before I push it through). |
Contributor
|
If it wasn't covered by #1525, I'd say it LGTM. |
Contributor
|
@shenghuy can you check if the bug is fixed in master? if it is not please rebase the PR against master and we can review it as part of the cold case PR cleanup please let us know within 5 days if you would like to do the above, otherwise the PR will be closed for inactivity |
alekstorm
pushed a commit
to alekstorm/incubator-airflow
that referenced
this pull request
Jun 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
The issue was that once a task is in QUEUED state, then it wont be checked against concurrency_reached for its dag, hence it will be set to RUNNING status. By adding this one more concurrency_reached check for all the QUEUED tasks, dag concurrency setting is now honored.
@mistercrunch