Fix AttributeError: 'datetime.timezone' object has no attribute 'name' #16599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Jun 22, 2021
This was referenced Jun 23, 2021
ecerulm
force-pushed
the
pendulumtimezone2
branch
from
9ce76cd to
cbbf4d4
Compare
Jorricks
pushed a commit
to Jorricks/airflow
that referenced
this pull request
Jun 24, 2021
… ``name`` (apache#16599) closes: apache#16551 Previous implementation tried to force / coerce the provided timezone (from the dag's `start_date`) into a `pendulum.tz.timezone.*` that only worked if the provided timezone was already a pendulum's timezone and it specifically failed when with `datetime.timezone.utc` as timezone.
jhtimmins
pushed a commit
that referenced
this pull request
Aug 9, 2021
… ``name`` (#16599) closes: #16551 Previous implementation tried to force / coerce the provided timezone (from the dag's `start_date`) into a `pendulum.tz.timezone.*` that only worked if the provided timezone was already a pendulum's timezone and it specifically failed when with `datetime.timezone.utc` as timezone. (cherry picked from commit 86c2091)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 13, 2021
… ``name`` (#16599) closes: #16551 Previous implementation tried to force / coerce the provided timezone (from the dag's `start_date`) into a `pendulum.tz.timezone.*` that only worked if the provided timezone was already a pendulum's timezone and it specifically failed when with `datetime.timezone.utc` as timezone. (cherry picked from commit 86c2091)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
… ``name`` (#16599) closes: #16551 Previous implementation tried to force / coerce the provided timezone (from the dag's `start_date`) into a `pendulum.tz.timezone.*` that only worked if the provided timezone was already a pendulum's timezone and it specifically failed when with `datetime.timezone.utc` as timezone. (cherry picked from commit 86c2091)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
… ``name`` (#16599) closes: #16551 Previous implementation tried to force / coerce the provided timezone (from the dag's `start_date`) into a `pendulum.tz.timezone.*` that only worked if the provided timezone was already a pendulum's timezone and it specifically failed when with `datetime.timezone.utc` as timezone. (cherry picked from commit 86c2091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #16551
Previous implementation tried to force / coerce the provided timezone (from the dag's
start_date) into apendulum.tz.timezone.*that only worked if the provided timezone was already a pendulum's timezone and it specifically failed when withdatetime.timezone.utcas timezone.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.