Add ODBC extra for the production image #18407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
mik-laj
reviewed
Sep 21, 2021
mik-laj
approved these changes
Sep 21, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
force-pushed
the
add-missing-odbc-extra
branch
from
ddd6dd2 to
4ae6e8b
Compare
ashb
reviewed
Sep 21, 2021
mik-laj
reviewed
Sep 21, 2021
scripts/ci/pre_commit/pre_commit_check_order_dockerfile_extras.py
Outdated
Show resolved
Hide resolved
The ODBC extra has been missing from apache#18382. This PR adds the missing extra and verifies if pyodbc is importable in the PROD image.
potiuk
force-pushed
the
add-missing-odbc-extra
branch
from
4ae6e8b to
9e85f77
Compare
Member
Author
|
Added extras to the docs :) |
mik-laj
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ODBC extra has been missing from #18382. This PR adds the
missing extra and verifies if pyodbc is importable in the PROD
image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.