Use seconds for schedule_delay metric

[coinzerge]

closes: #18599

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[ashb]

This belongs in the DataDogstatsd adapter inside airflow.stats -- as the normal statsd client accepts timedelta.

I.e. add an isinstance check in here

airflow/airflow/stats.py

Lines 333 to 339 in abdede8

	@validate_stat
	def timing(self, stat, dt, tags=None):
	"""Stats timing"""
	if self.allow_list_validator.test(stat):
	tags = tags or []
	return self.dogstatsd.timing(metric=stat, value=dt, tags=tags)
	return None

[uranusjr]

Agreed, the stat backend should be able to handle timedelta instead.

[coinzerge]

@ashb @uranusjr updated PR

[uranusjr]

Could you add a test for this in tests/core/test_stats.py? And while we're at it, we should also add annotations to dt in the stats module to make it explicit it can be either float or timedelta.

[coinzerge]

added test. what do you mean by we should also add annotations?

[uranusjr]

Function parameter annotations. The functions are already partially annotated, but we should annotate dt with Union[float, datetime.timedelta].

[coinzerge]

@uranusjr anything else i need to do to merge the PR?

[uranusjr]

You need to first fix the static checks and tests. Looks like your Union import is breaking things.

[potiuk]

Now tests are faling

[ashb]

I'm still not 100% sure this is "right" as many of the timer metrics we track are <1s, so this would just submit 0 values for them making them useless.

[ashb]

I've just double checked and no, this is not right.

Using the code example from https://docs.datadoghq.com/metrics/dogstatsd_metrics_submission/#timer

from datadog import initialize, statsd
import time
import random

options = {
    'statsd_host':'127.0.0.1',
    'statsd_port':8125
}

initialize(**options)

@statsd.timed('example_metric.timer', tags=["environment:dev,function:my_function"])
def my_function():
  time.sleep(random.randint(0, 10))

my_function()

this is what I see submited to statsd:

example_metric.timer:1.836400042520836e-05|ms|#environment:dev_function:my_function

[coinzerge]

what's not right? total_seconds returns a float.

[ashb]

what's not right? total_seconds returns a float.

🤦🏻 Of course it does. I thought it was integer seconds only. Sorry

I can't python

[kaxil]

Tests are failing, can you take a look plz

[eladkal]

@coinzerge can you please fix the test failure?
tests/core/test_stats.py::TestDogStats::test_timing: AssertionError: Expected 'timing' to be called once. Called 2 times.

[ashb]

Fixed by #19973