Skip to content

Conversation

@Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Oct 11, 2021

closes: #18851
Fix for breeze setup-autocomplete in zsh shell terminal. As discussed in issue #18851 error is thrown out after executing the command
$source ~/.bash_completion.d/breeze-complete
Fix includes:

  1. Change in instruction to reload .zshrc
  2. Reloading zshrc in breeze.

Test: I have tested in my environment by reverting the changes that ./breeze setup-autocomplete has made. Added the fix and verified by running ./breeze setup-complete command again.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 11, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit ec31b20 into apache:main Oct 11, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 11, 2021

Awesome work, congrats on your first merged pull request!

potiuk pushed a commit that referenced this pull request Jan 22, 2022
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 22, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

command not found: complete when using bash completion for breeze setup-autocomplete

2 participants