Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 12, 2021

The RUN_*TEST variables are not part of the environment
so they are not set when the dc_ci is generated they are
overridden by Breeze when particular commands are executed.
Therefore we should not hard-code those values in dc_ci script
(this is useful for debugging to have the script but it is only
there for environment configuration)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@uranusjr
Copy link
Member

This seems to skip all tests unconditionally

Starting the tests with those pytest arguments: --verbosity=0 --strict-markers --durations=100 --cov=airflow/
--cov-config=.coveragerc --cov-report=xml:/files/coverage-All-sqlite.xml --color=yes --maxfail=50
--pythonwarnings=ignore::DeprecationWarning --pythonwarnings=ignore::PendingDeprecationWarning
--junitxml=/files/test_result-All-sqlite.xml --timeouts-order moi --setup-timeout=60 --execution-timeout=60
--teardown-timeout=60 -rfEX --with-db-init --integration false
tests/api_connexion/endpoints/test_role_and_permission_endpoint.py

platform linux -- Python 3.7.12, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /opt/airflow, configfile: pytest.ini
plugins: rerunfailures-9.1.1, xdist-2.4.0, requests-mock-1.9.3, forked-1.3.0, asyncio-0.15.1, cov-3.0.0,
anyio-3.3.3, flaky-3.7.0, timeouts-1.2.1, instafail-0.4.2, httpx-0.13.0
setup timeout: 60.0s, execution timeout: 60.0s, teardown timeout: 60.0s
collected 44 items

tests/api_connexion/endpoints/test_role_and_permission_endpoint.py ssssssssssssssssssssssssssssssssssssssssssss

(line breaks added manually to make things easier to read)

@potiuk
Copy link
Member Author

potiuk commented Oct 12, 2021

--integration false causes it. Let me see where it comes from

@potiuk
Copy link
Member Author

potiuk commented Oct 12, 2021

--integration false causes it. Let me see where it comes from

BTW. ./breeze --verbose tells much more what happens :)

@potiuk
Copy link
Member Author

potiuk commented Oct 12, 2021

And VERBOSE_COMMANDS="true" ./breeze .... even more

@potiuk
Copy link
Member Author

potiuk commented Oct 12, 2021

(and the output is saved in .breeze/breeze.out)

The RUN_*TEST variables are not part of the environment
so they are not set when the dc_ci is generated they are
overridden by Breeze when particular commands are executed.
Therefore we should not hard-code those values in dc_ci script
(this is useful for debugging to have the script but it is only
there for environment configuration)
@potiuk potiuk force-pushed the fix-running-tests-in-breeze branch from 25527e2 to 6a979c1 Compare October 12, 2021 09:37
@potiuk potiuk requested a review from ashb as a code owner October 12, 2021 09:37
@potiuk
Copy link
Member Author

potiuk commented Oct 12, 2021

The RUN_INTEGRATION_TESTS variable was wrong name (I have fallen into the trap that I set myself).
It should be either empty (regular tests) or contain the list of integrations enabled (if we run integration tests).

I updated it across the board to LIST_OF_INTEGRATION_TESTS to better refect what it is and tested both integration and non-integration cases. Should work now !

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix it

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 12, 2021
@potiuk potiuk merged commit 7d3b6b5 into apache:main Oct 12, 2021
@potiuk potiuk deleted the fix-running-tests-in-breeze branch October 12, 2021 10:19
potiuk added a commit that referenced this pull request Jan 22, 2022
The RUN_*TEST variables are not part of the environment
so they are not set when the dc_ci is generated they are
overridden by Breeze when particular commands are executed.
Therefore we should not hard-code those values in dc_ci script
(this is useful for debugging to have the script but it is only
there for environment configuration)

(cherry picked from commit 7d3b6b5)
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 22, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Jan 22, 2022
@potiuk potiuk restored the fix-running-tests-in-breeze branch April 26, 2022 20:50
@potiuk potiuk deleted the fix-running-tests-in-breeze branch July 29, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants