-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Remove adding of "test-run" variables to dc_ci script #18903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This seems to skip all tests unconditionally (line breaks added manually to make things easier to read) |
|
|
BTW. |
|
And |
|
(and the output is saved in |
The RUN_*TEST variables are not part of the environment so they are not set when the dc_ci is generated they are overridden by Breeze when particular commands are executed. Therefore we should not hard-code those values in dc_ci script (this is useful for debugging to have the script but it is only there for environment configuration)
25527e2 to
6a979c1
Compare
|
The I updated it across the board to |
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fix it
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
The RUN_*TEST variables are not part of the environment so they are not set when the dc_ci is generated they are overridden by Breeze when particular commands are executed. Therefore we should not hard-code those values in dc_ci script (this is useful for debugging to have the script but it is only there for environment configuration) (cherry picked from commit 7d3b6b5)
The RUN_*TEST variables are not part of the environment
so they are not set when the dc_ci is generated they are
overridden by Breeze when particular commands are executed.
Therefore we should not hard-code those values in dc_ci script
(this is useful for debugging to have the script but it is only
there for environment configuration)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.