Skip to content

Conversation

@simplylizz
Copy link
Contributor

Add possibility to set resource limits and requests for airflow-migration-job.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 22, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 22, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@simplylizz simplylizz requested a review from mik-laj October 23, 2021 08:25
simplylizz and others added 2 commits October 23, 2021 13:34
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
@mik-laj mik-laj merged commit 6ad837c into apache:main Oct 23, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 23, 2021

Awesome work, congrats on your first merged pull request!

@simplylizz
Copy link
Contributor Author

https://github.com/apache/airflow/runs/3984371457?check_suite_focus=true#step:8:4114 - @mik-laj I see one test is failing after merging. Should I bother with it or they are just flaky?

@mik-laj
Copy link
Member

mik-laj commented Oct 23, 2021

It looks like a flaky test.

sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
* Add migration job resources

* Add change notes

* Fix test

* Linter

* Update chart/values.schema.json

* Update chart/values.schema.json

Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>

* Linter

Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants