Skip to content

Conversation

@ShaharPotash1
Copy link
Contributor

As already written in this issue #19241 strptime function required string, but got proxy if the variables ds/next_ds (the types of these variables changed on version 2.2.0) sent.
This change will make the function ds_add and ds_format backward compatible.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

…t Proxy)

As already written in this issue apache#19241 strptime function required string, but got proxy if the variables ds/next_ds (the types of these variables changed on version 2.2.0) sent.
@ShaharPotash1 ShaharPotash1 changed the title Cast ds macro functions Cast to string in ds macro functions Oct 27, 2021
@uranusjr
Copy link
Member

Can you add tests for this? This should be done by adding a new file at tests/macros/test_macros.py with two test functions, one each for calling ds_add and ds_format with a lazy object proxy.

@dstandish dstandish self-requested a review October 30, 2021 05:32
@potiuk
Copy link
Member

potiuk commented Nov 8, 2021

@ShaharPotash1 - any chance to add the tests?

@uranusjr
Copy link
Member

I’m finishing the PR in #19592.

@potiuk potiuk closed this Nov 24, 2021
@potiuk
Copy link
Member

potiuk commented Nov 24, 2021

Being finished in #19592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants