Skip to content

Conversation

@Aakcht
Copy link
Contributor

@Aakcht Aakcht commented Oct 27, 2021

Currently it's not possible to configure createUser Job and cleanup cronjob resources. This PR makes resources of these jobs configurable.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 27, 2021
@Aakcht Aakcht force-pushed the chart_job_resources branch from 7129b4b to 2787be8 Compare October 27, 2021 19:42
@Aakcht
Copy link
Contributor Author

Aakcht commented Oct 27, 2021

Looks like the failing check is not related to this PR: Error: Process completed with exit code 137.

@mik-laj
Copy link
Member

mik-laj commented Oct 28, 2021

We have a few options for resource configuration, but no documentation about it.

workers.kerberosSidecar.resources
workers.resources
workers.logGroomerSidecar.resources
scheduler.resources
scheduler.logGroomerSidecar.resources
triggerer.resources
migrateDatabaseJob.resources
webserver.resources
flower.resources
statsd.resources
pgbouncer.resources
pgbouncer.metricsExporterSidecar.resources
redis.resources
dags.gitSync.resources

Would you take the time to describe it?

@mik-laj
Copy link
Member

mik-laj commented Oct 28, 2021

CC: @simplylizz

@Aakcht
Copy link
Contributor Author

Aakcht commented Oct 28, 2021

@mik-laj
Copy link
Member

mik-laj commented Oct 28, 2021

@Aakcht We have reference documentation that allows a Helm / Kubernetes expert to take advantage of this option. However, we lack a guide that will allow a less experienced user to use this feature.

For example, Kubernetes has a page that describes how to create a deployment object.
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/
Butt they have a reference page for this object type:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#deployment-v1-apps

@Aakcht
Copy link
Contributor Author

Aakcht commented Oct 28, 2021

@mik-laj Do you think something like http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/helm-chart/latest/using-additional-containers.html would work? I can add a similar page for the container resources.

@mik-laj
Copy link
Member

mik-laj commented Oct 28, 2021

Yes. Exactly.

@kaxil
Copy link
Member

kaxil commented Oct 28, 2021

Good idea @mik-laj

@Aakcht Aakcht force-pushed the chart_job_resources branch 2 times, most recently from efd8281 to 1cab492 Compare October 28, 2021 13:28
@Aakcht Aakcht force-pushed the chart_job_resources branch from 1cab492 to 1f45aa7 Compare October 28, 2021 14:47
@Aakcht
Copy link
Contributor Author

Aakcht commented Oct 28, 2021

@mik-laj @kaxil I've added the page for the container resources, please take a look.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 30, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj mik-laj merged commit a355213 into apache:main Oct 30, 2021
@Aakcht Aakcht deleted the chart_job_resources branch October 30, 2021 18:30
@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.3.0 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants