-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Chart: add resources for cleanup and createuser jobs #19263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7129b4b to
2787be8
Compare
|
Looks like the failing check is not related to this PR: |
|
We have a few options for resource configuration, but no documentation about it. Would you take the time to describe it? |
|
CC: @simplylizz |
|
@mik-laj , do you want to describe it specifically on the page http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/helm-chart/latest/index.html ? From what I see, the parameters reference is available at http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/helm-chart/latest/parameters-ref.html and it already includes documentation about possible resource configuration. See https://github.com/apache/airflow/blob/main/docs/helm-chart/parameters-ref.rst and https://github.com/apache/airflow/blob/main/docs/conf.py . |
|
@Aakcht We have reference documentation that allows a Helm / Kubernetes expert to take advantage of this option. However, we lack a guide that will allow a less experienced user to use this feature. For example, Kubernetes has a page that describes how to create a deployment object. |
|
@mik-laj Do you think something like http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/helm-chart/latest/using-additional-containers.html would work? I can add a similar page for the container resources. |
|
Yes. Exactly. |
|
Good idea @mik-laj |
efd8281 to
1cab492
Compare
1cab492 to
1f45aa7
Compare
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Currently it's not possible to configure createUser Job and cleanup cronjob resources. This PR makes resources of these jobs configurable.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.