[AIRFLOW-649] Support non-sched DAGs in LatestOnlyOp #1956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
criccomini
approved these changes
Dec 22, 2016
Contributor
criccomini
left a comment
criccomini
left a comment
There was a problem hiding this comment.
LGTM
Left a nit. If you feel compelled, go ahead and fix. Either way, good with a merge.
Contributor
There was a problem hiding this comment.
Nit: not sure about newline in log message. Usually this is poor form, as it breaks parsers and whatnot.
Contributor
Author
|
@criccomini Removed newline! |
Current coverage is 66.52% (diff: 0.00%)@@ master #1956 diff @@
==========================================
Files 135 135
Lines 10201 10204 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6790 6788 -2
- Misses 3411 3416 +5
Partials 0 0
|
alekstorm
pushed a commit
to alekstorm/incubator-airflow
that referenced
this pull request
Jun 1, 2017
Closes apache#1956 from r39132/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
Testing Done:
Here's a screen shot, which shows 1 scheduled run and 2 manually triggered runs.
https://www.dropbox.com/s/vch7ohdx5he7xnw/Screenshot%202016-12-21%2023.10.22.png?dl=0