Relax timetable clas validation #19878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airflow regularly reloads sys.modules, which makes type identity comparison unreliable, because a class would obtain a second, different identity in the interpreter when imported after a reload. This makes validation difficult because there isn't really a way to tell whether two class objects are indeed "the same". But this check is only for sanity to begin with, so the best we can do is to drop the check entirely ans trust the Plugin Manager is doing its job correctly.
potiuk
approved these changes
Nov 29, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Member
|
Ah. That would explain why I had some problems in some of the tests with comparing classes. |
dillonjohnson
pushed a commit
to dillonjohnson/airflow
that referenced
this pull request
Dec 1, 2021
Airflow regularly reloads sys.modules, which makes type identity comparison unreliable, because a class would obtain a second, different identity in the interpreter when imported after a reload. This makes validation difficult because there isn't really a way to tell whether two class objects are indeed "the same". But this check is only for sanity to begin with, so the best we can do is to drop the check entirely ans trust the Plugin Manager is doing its job correctly.
jedcunningham
pushed a commit
that referenced
this pull request
Dec 7, 2021
Airflow regularly reloads sys.modules, which makes type identity comparison unreliable, because a class would obtain a second, different identity in the interpreter when imported after a reload. This makes validation difficult because there isn't really a way to tell whether two class objects are indeed "the same". But this check is only for sanity to begin with, so the best we can do is to drop the check entirely ans trust the Plugin Manager is doing its job correctly. (cherry picked from commit 7d555d7)
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow regularly reloads
sys.modules, which makes type identity comparison unreliable, because a class would obtain a second, different identity in the interpreter when imported after a reload.This makes validation difficult because there isn't really a way to tell whether two class objects are indeed "the same". But this check is only for sanity to begin with, so the best we can do is to drop the check entirely ans trust the Plugin Manager is doing its job correctly.
Fix #19869.