Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 5, 2021

Seems that when the system is busy, the timeouts we had to
wait for tasks to start were a bit to short. Increasing them.

Related to #20054


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Seems that when the system is busy, the timeouts we had to
wait for tasks to start were a bit to short. Increasing them.

Related to apache#20054
@potiuk potiuk requested a review from eladkal December 5, 2021 19:12
@potiuk
Copy link
Member Author

potiuk commented Dec 5, 2021

the timeouts were a bit too short still :(

@potiuk
Copy link
Member Author

potiuk commented Dec 5, 2021

The failing tests are not related and fixed in #19860

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 5, 2021
@potiuk potiuk merged commit 5a4eb84 into apache:main Dec 5, 2021
@potiuk potiuk deleted the slightly-longer-on-kill-timeouts branch December 5, 2021 20:05
@potiuk potiuk restored the slightly-longer-on-kill-timeouts branch April 26, 2022 20:49
@potiuk potiuk deleted the slightly-longer-on-kill-timeouts branch July 29, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants