Skip to content

Fix google cred links #20075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashb wants to merge 1 commit into from
Closed

Fix google cred links #20075

ashb wants to merge 1 commit into from

Conversation

@ashb
Copy link
Member

@ashb ashb commented Dec 6, 2021

Before:

image

After:

image

@ashb ashb requested review from kaxil, mik-laj and potiuk December 6, 2021 16:16
@boring-cyborg boring-cyborg bot added area:core-operators provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers area:Scheduler including HA (high availability) scheduler kind:documentation provider:google Google (including GCP) related issues labels Dec 6, 2021
@ashb

This comment has been minimized.

Sign in to view
@ashb ashb force-pushed the fix-google-cred-links branch from 72611aa to 7fce5e2 Compare December 6, 2021 16:19
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 6, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

dstandish
dstandish approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@dstandish dstandish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were a lot more changes a second ago was about to ask :)

@ashb
Copy link
Member Author

ashb commented Dec 6, 2021

there were a lot more changes a second ago was about to ask :)

Yeah, that is for upgrading sphinx and sphinx-autoapi (which is how I noticed this -- it caused an warning in more recent versions.)

@ashb
Copy link
Member Author

ashb commented Dec 6, 2021

I'll merge this after docs build has passed.

@ashb
Copy link
Member Author

ashb commented Dec 6, 2021

.... which they didn't. Wat.

@ashb
Copy link
Member Author

ashb commented Dec 6, 2021

Fine, I will roll this in to the sphinx upgrade instead.

@ashb ashb closed this Dec 6, 2021
@ashb ashb deleted the fix-google-cred-links branch December 6, 2021 16:37
@ashb
Copy link
Member Author

ashb commented Dec 6, 2021

#20079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@dstandish dstandish dstandish approved these changes

@kaxil kaxil Awaiting requested review from kaxil

@mik-laj mik-laj Awaiting requested review from mik-laj

@turbaszek turbaszek Awaiting requested review from turbaszek

@vikramkoka vikramkoka Awaiting requested review from vikramkoka

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

Assignees

No one assigned

Labels

area:providers area:Scheduler including HA (high availability) scheduler kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashb @potiuk @dstandish