Fix log link in gantt view #20121
Fix log link in gantt view #20121
Conversation
jedcunningham
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
| task_dict['extraLinks'] = dag.get_task(ti.task_id).extra_links | ||
| task_dict['try_number'] = try_count | ||
| task_dict['execution_date'] = dttm | ||
| task_dict['execution_date'] = dttm.isoformat() |
There was a problem hiding this comment.
Sign I really hate this subtle T and space difference in Python’s datetime.
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
(cherry picked from commit f59decd)
3 participants
The link to the log in the gantt view modal was a broken link as the execution_date wasn't isoformatted.
Closes #19613