Skip to content

Conversation

@bhavaniravi
Copy link
Contributor

Part of #20139 - organize aws emr operators

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladkal
Copy link
Contributor

eladkal commented Dec 14, 2021

@bhavaniravi can you please take a look at test failures?

@eladkal
Copy link
Contributor

eladkal commented Dec 15, 2021

CI is still sad :(

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +34 to +39
- :class:`~airflow.providers.amazon.aws.sensors.emr.EmrJobFlowSensor`
- :class:`~airflow.providers.amazon.aws.sensors.emr.EmrStepSensor`
- :class:`~airflow.providers.amazon.aws.operators.emr.EmrCreateJobFlowOperator`
- :class:`~airflow.providers.amazon.aws.operators.emr.EmrAddStepsOperator`
- :class:`~airflow.providers.amazon.aws.operators.emr.EmrModifyClusterOperator`
- :class:`~airflow.providers.amazon.aws.operators.emr.EmrTerminateJobFlowOperator`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is also missing EmrContainerOperator would you mind adding it in a followup PR?

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 16, 2021
@eladkal eladkal removed the full tests needed We need to run full set of tests for this PR to merge label Dec 16, 2021
@eladkal eladkal merged commit a387061 into apache:main Dec 16, 2021
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants