Skip to content

Conversation

@Aakcht
Copy link
Contributor

@Aakcht Aakcht commented Dec 9, 2021

To avoid unnecessary warnings provider import errors can be logged as debug logs, see #14903. However, it was changed in #17625. This PR changes provider import errors log level back to debug again.

closes #20159


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@Aakcht Aakcht force-pushed the provider_import_debug_warnings branch from ad4eb08 to f13ec05 Compare December 9, 2021 17:17
@Aakcht Aakcht force-pushed the provider_import_debug_warnings branch from f13ec05 to 326c40b Compare December 9, 2021 19:51
@potiuk potiuk added this to the Airflow 2.2.3 milestone Dec 9, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Dec 9, 2021

Yeah. I think there is indeed very little value to warn "early" here (if any) . Even if import error is "legitimate" (i.e. there is some real import error other than not installed libraries) then you would get error when you try to use the faulty class. Which is far better place for any problems like that.

@Aakcht
Copy link
Contributor Author

Aakcht commented Dec 9, 2021

I can try rebasing again if needed, but it looks like the failing check is not related to this PR:

 error pulling image configuration: Get "https://centralus.data.mcr.microsoft.com/795a02ce1e3547eb8d4b8a7d06af7541-39qwoxxdjo//docker/registry/v2/blobs/sha256/47/47e4878b63746ba0df141688cce41aec224bd0d932ac073a0e04aba942b2bb4a/data?P1=1639081027&P2=1&P3=1&P4=CBIrt%2B7ZCG6tBfqEQ%2Fsx8i6D%2FgGxeFASAZsweCRI87A%3D&se=2021-12-09T20%3A17%3A07Z&sig=HwrQ9D05gihpTxESAfrurgpO%2FSp0RoC6fesv%2B16vTmA%3D&sp=r&spr=https&sr=b&sv=2016-05-31&regid=795a02ce1e3547eb8d4b8a7d06af7541": dial tcp 204.79.197.219:443: i/o timeout

@potiuk
Copy link
Member

potiuk commented Dec 9, 2021

Oh yeah. MS not really collaborating.

@potiuk potiuk merged commit 82102e6 into apache:main Dec 9, 2021
@Aakcht Aakcht deleted the provider_import_debug_warnings branch December 10, 2021 07:09
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Dec 10, 2021
jedcunningham pushed a commit that referenced this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary warnings during airflow pods starts

3 participants