-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix cached_property MyPy declaration and related MyPy errors #20226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cached_property MyPy declaration and related MyPy errors #20226
Conversation
090d3ad to
137aa92
Compare
|
@potiuk Have you tried the version check change suggested by @uranusjr in the thread of #19891 to fix the if sys.version_info >= (3, 8):
from functools import cached_property
else:
from cached_property import cached_property@subkanthi tried this and it did not work in his testing (see comment) but I made the change to the Azure provider in my testing and it did resolve the MyPy error. |
Good point. let me try. |
Yep. Seems to work @josh-fell ! Good call! |
137aa92 to
8d60fd8
Compare
|
Much nicer - with far less type-ignores . Thanks Josh for the hint! |
|
This one fixes a lot :). |
|
Would love to merge that one as it fixes a lot of issues and we could see the progress ;) |
|
Conflits though 😞 |
8d60fd8 to
d1850ff
Compare
d1850ff to
09bdeb2
Compare
|
Rebased. Also get rid of the strict-optional from the automl google library |
Part of #19891
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.