Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 12, 2021

Part of #19891


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested a review from turbaszek as a code owner December 12, 2021 11:49
@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:logging area:providers area:secrets provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Dec 12, 2021
@potiuk potiuk force-pushed the fix-attr-defined-for-cached-property branch from 090d3ad to 137aa92 Compare December 12, 2021 12:38
@potiuk potiuk mentioned this pull request Dec 12, 2021
@potiuk potiuk added the mypy Fixing MyPy problems after bumpin MyPy to 0.990 label Dec 13, 2021
@josh-fell
Copy link
Contributor

josh-fell commented Dec 13, 2021

@potiuk Have you tried the version check change suggested by @uranusjr in the thread of #19891 to fix the cached_property errors instead of the # type: ignore[attr-defined] comment?

if sys.version_info >= (3, 8):
    from functools import cached_property
else:
    from cached_property import cached_property

@subkanthi tried this and it did not work in his testing (see comment) but I made the change to the Azure provider in my testing and it did resolve the MyPy error.

@potiuk
Copy link
Member Author

potiuk commented Dec 13, 2021

@potiuk Have you tried the version check change suggested by @uranusjr in the thread of #19891 to fix the cached_property errors instead of the # type: ignore[attr-defined] comment?

Good point. let me try.

@potiuk
Copy link
Member Author

potiuk commented Dec 13, 2021

@potiuk Have you tried the version check change suggested by @uranusjr in the thread of #19891 to fix the cached_property errors instead of the # type: ignore[attr-defined] comment?

Yep. Seems to work @josh-fell ! Good call!

@potiuk potiuk force-pushed the fix-attr-defined-for-cached-property branch from 137aa92 to 8d60fd8 Compare December 13, 2021 17:51
@potiuk
Copy link
Member Author

potiuk commented Dec 13, 2021

Much nicer - with far less type-ignores . Thanks Josh for the hint!

@potiuk
Copy link
Member Author

potiuk commented Dec 13, 2021

This one fixes a lot :).

@potiuk
Copy link
Member Author

potiuk commented Dec 14, 2021

Would love to merge that one as it fixes a lot of issues and we could see the progress ;)

@uranusjr
Copy link
Member

Conflits though 😞

@potiuk potiuk force-pushed the fix-attr-defined-for-cached-property branch from 8d60fd8 to d1850ff Compare December 15, 2021 18:33
@potiuk potiuk force-pushed the fix-attr-defined-for-cached-property branch from d1850ff to 09bdeb2 Compare December 15, 2021 18:37
@potiuk
Copy link
Member Author

potiuk commented Dec 15, 2021

Rebased. Also get rid of the strict-optional from the automl google library

@potiuk potiuk merged commit 2fb5e1d into apache:main Dec 15, 2021
@potiuk potiuk deleted the fix-attr-defined-for-cached-property branch December 15, 2021 22:51
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2022
@potiuk potiuk restored the fix-attr-defined-for-cached-property branch April 26, 2022 20:54
@potiuk potiuk deleted the fix-attr-defined-for-cached-property branch July 29, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers area:secrets changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) mypy Fixing MyPy problems after bumpin MyPy to 0.990 provider:amazon AWS/Amazon - related issues provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants