Remove Integration tests from MSSQL on Public Runners #20231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Integration tests with MSSQL often fail on Public Runners without a reason. The database becomes inaccessible and no logs are explaining what's going on. Its very likely however that this is a memory-related issue (Integration tests take a lot of memory as they run a lot of extra containers. Those tests will eventually run on Self-hosted runner after merge and they are also run for Postgres/MySQL/SQlite so there is no need to run them also for MSSQL if it causes random failures.
potiuk
force-pushed
the
skip-integration-tests-for-mssql
branch
from
3bfbd75 to
33a4d7e
Compare
Member
Author
|
That one shoudl help (:crossed_fingers: ) with occassional MSSQL failures happening for Public runners recently! |
kaxil
approved these changes
Dec 13, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
approved these changes
Dec 13, 2021
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
No objections from me, although someone probably will need to pay attention on build results in main after this. I don’t most of the time, to be honest.
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
The Integration tests with MSSQL often fail on Public Runners without a reason. The database becomes inaccessible and no logs are explaining what's going on. Its very likely however that this is a memory-related issue (Integration tests take a lot of memory as they run a lot of extra containers. Those tests will eventually run on Self-hosted runner after merge and they are also run for Postgres/MySQL/SQlite so there is no need to run them also for MSSQL if it causes random failures. (cherry picked from commit d1848bc)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
The Integration tests with MSSQL often fail on Public Runners without a reason. The database becomes inaccessible and no logs are explaining what's going on. Its very likely however that this is a memory-related issue (Integration tests take a lot of memory as they run a lot of extra containers. Those tests will eventually run on Self-hosted runner after merge and they are also run for Postgres/MySQL/SQlite so there is no need to run them also for MSSQL if it causes random failures. (cherry picked from commit d1848bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Integration tests with MSSQL often fail on Public
Runners without a reason. The database becomes inaccessible and
no logs are explaining what's going on. Its very likely however
that this is a memory-related issue (Integration tests take a
lot of memory as they run a lot of extra containers.
Those tests will eventually run on Self-hosted runner after merge
and they are also run for Postgres/MySQL/SQlite so there is no
need to run them also for MSSQL if it causes random failures.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.